Skip to content

Add Emoji Highlighter#71

Open
maxmmitchell wants to merge 2 commits into
mainfrom
add-emoji-highlighter
Open

Add Emoji Highlighter#71
maxmmitchell wants to merge 2 commits into
mainfrom
add-emoji-highlighter

Conversation

@maxmmitchell
Copy link
Copy Markdown
Contributor

@maxmmitchell maxmmitchell commented May 8, 2026

  • Add logic to make these three new stock brushes available in Cahier stock brush store, leveraging the existing emoji highlighter brush from the Ink API
  • Add requisite textures for three emojis: heart, star, and the ever-popular poop emoji
  • Add emoji highlighter as an option when drawing in a Cahier note, and in the brush designer canvas
  • Add submenu to select from three available options
  • Add SVGs to adorn the new menu options

Similar menu options will be added to brush graph within that branch after this merges and I can pull the changes in.

@maxmmitchell maxmmitchell marked this pull request as ready for review May 8, 2026 18:11
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Emoji Highlighter brushes (Heart, Star, and Poop) by adding new vector assets, texture mappings, and serialization support. It also implements submenus in the Brush Designer and Drawing Toolbox to select these brushes. Feedback highlights a potential serialization issue when using dynamic brush instances as map keys, efficiency concerns and incorrect color literals in the ViewModel, visual inconsistency in the Poop emoji icon, and the use of brittle hardcoded UI offsets.

Comment thread app/src/main/java/com/example/cahier/core/ui/Converters.kt
Comment thread app/src/main/res/drawable/ic_emoji_poop.xml
Comment thread app/src/main/java/com/example/cahier/features/drawing/DrawingToolbox.kt Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant