Add Emoji Highlighter#71
Open
maxmmitchell wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Emoji Highlighter brushes (Heart, Star, and Poop) by adding new vector assets, texture mappings, and serialization support. It also implements submenus in the Brush Designer and Drawing Toolbox to select these brushes. Feedback highlights a potential serialization issue when using dynamic brush instances as map keys, efficiency concerns and incorrect color literals in the ViewModel, visual inconsistency in the Poop emoji icon, and the use of brittle hardcoded UI offsets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar menu options will be added to brush graph within that branch after this merges and I can pull the changes in.