Add drop-in replacement of load_pdi with control-packet-based configuration - #3
Open
andrej wants to merge 26 commits into
Open
Add drop-in replacement of load_pdi with control-packet-based configuration#3andrej wants to merge 26 commits into
load_pdi with control-packet-based configuration#3andrej wants to merge 26 commits into
Conversation
andrej
force-pushed
the
simplify-aiecc
branch
3 times, most recently
from
July 13, 2026 16:06
e876d97 to
ccbf6da
Compare
andrej
force-pushed
the
simplify-aiecc
branch
5 times, most recently
from
July 17, 2026 04:55
8a80e2a to
71080a1
Compare
andrej
force-pushed
the
full-elf-ctrlpkt
branch
2 times, most recently
from
July 17, 2026 19:58
0f17a66 to
a358199
Compare
…O artifacts (Xilinx#3356) Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…NOC (Xilinx#3293) Co-authored-by: Claude <noreply@anthropic.com>
…r rolled runtime sequences (Xilinx#3358) Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
andrej
force-pushed
the
full-elf-ctrlpkt
branch
2 times, most recently
from
July 21, 2026 20:00
21033f8 to
b1d7529
Compare
Co-authored-by: André Rösti <androsti@amd.com>
Reorder the default (--expand-load-pdis) flow so load_pdi expansion runs at the same point as the ctrl-pkt flow: materialize -> expand -> DMA lowering. Factor runtime-sequence materialization out of getNpuLoweringPipeline into an explicit 'npu_materialized.mlir' graph edge (inspectable intermediate), and collapse the two per-flow expand edges into a single 'npu_expanded.mlir' edge parameterized by ctrl-pkt. getNpuLoweringPipeline becomes getNpuDmaLoweringPipeline (DMA tail only).
Drop change-narration and restatement from the NPU-lowering comments (no before/after framing, no 'still'/'kept'/'at the same point', no paraphrasing of adjacent code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for a mode of
--expand-load-pdisthat replaces allload_pdiinstructions withload_pdiinstruction that loads a minimal column control overlay -- the routes for the control packets.Also plumbs in the control packet data into the full ELF format.