LlamaFactory Playbook Review of PR #313#319
Merged
Merged
Conversation
ldokovic-personal
approved these changes
Jun 1, 2026
sreeram-11
merged commit c1c70d7
into
ldokovic/llama-factory-finetuning
18 of 19 checks passed
ldokovic-personal
added a commit
that referenced
this pull request
Jun 2, 2026
…oss all OS's and GPU devices (#313) * Playbook Improvements - making it stable for launch across all platforms and GPU devices * LlamaFactory Playbook Review of PR #313 (#319) * Cleanup * Extended timeout for training, updated CI test for Windows training * Updating Windows code fence to Powershell from Bash * Updating export-llamafactory-model Windows test * Keeping `@devices` tag to eliminate the need to create `~/.venv` on AI Halo devices * Moving 'Create a Venv' title to avoid emtpty header on AIHalo --------- Co-authored-by: Sreeram <s.sreeram.amd@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The below changes resolve the failing CI tests in PR #313.
quick-train-llamafactory-loratest to 3600sexport-llamafactory-modeltestbashtopowershell<!-- @os:linux, windows -->tags