Fix gpt-oss summaries printing raw reasoning instead of final answer#314
Open
maxdokukin-amd wants to merge 1 commit into
Open
Fix gpt-oss summaries printing raw reasoning instead of final answer#314maxdokukin-amd wants to merge 1 commit into
maxdokukin-amd wants to merge 1 commit into
Conversation
…oning-effort control, properly extracting the final channel, and detecting incomplete generations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous version printed only gpt-oss reasoning tokens (mid-thought, often truncated) instead of the final answer. This version extracts the Harmony final channel, raises max tokens, and adds reasoning-effort control.