[pytorch-kernels] General Improvements#246
Open
ldokovic-personal wants to merge 10 commits into
Open
Conversation
ldokovic-personal
force-pushed
the
ldokovic/pytorch-kernels-ReadMe
branch
from
2fe342e to
27534d0
Compare
ldokovic-personal
changed the title
adamlam2-amd
force-pushed
the
ldokovic/pytorch-kernels-ReadMe
branch
from
27534d0 to
f00dee6
Compare
adamlam2-amd
changed the title
…amd/halo_playbooks into ldokovic/pytorch-kernels-ReadMe
Collaborator
|
@sdevinenamd - any update on the Windows version of this playbook? I couldn't get it to work |
sreeram-11
reviewed
Jun 3, 2026
sreeram-11
reviewed
Jun 3, 2026
| ### Create a Virtual Environment | ||
| <!-- @os:linux --> | ||
| On Linux, open a terminal in the directory of your choice and follow the commands to create a venv with ROCm+Pytorch already installed. | ||
| <!-- @test:id=create-venv timeout=120 --> |
Collaborator
There was a problem hiding this comment.
Please remove @test tags.
The test env-setup-rocm-pytorch-linux verifies venv creation and activation.
sreeram-11
reviewed
Jun 3, 2026
sreeram-11
reviewed
Jun 3, 2026
| <!-- @os:windows --> | ||
| ### Prerequisites - Windows | ||
| - Install latest: [AMD Adrenalin Software](https://www.amd.com/en/products/software/adrenalin.html) | ||
| <!-- @setup:id=activate-venv command="kernel-env\Scripts\activate.bat" --> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <!-- @setup:id=activate-venv command="kernel-env\Scripts\activate.bat" --> | |
| <!-- @setup:id=activate-venv command="kernel-env\Scripts\activate" --> |
The CI tests run in PowerShell (not CMD), so this command should work there as well.
sreeram-11
reviewed
Jun 3, 2026
sreeram-11
reviewed
Jun 3, 2026
| ### Installing Dependencies | ||
| <!-- @os:linux --> | ||
| On Linux, open a terminal in the directory of your choice and follow the commands to create a venv. | ||
| <!-- @test:id=create-venv timeout=120 --> |
Collaborator
There was a problem hiding this comment.
Please remove @test tags.
The test env-setup-rocm-pytorch-linux verifies venv creation and activation.
sreeram-11
reviewed
Jun 3, 2026
Collaborator
sreeram-11
left a comment
sreeram-11
left a comment
There was a problem hiding this comment.
Update Windows code blocks to use powershell instead of bash wherever applicable.
Collaborator
|
Looping in @sdevinenamd for review. |
adamlam2-amd
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update to the README clarifies setup steps for gfx1151 architecture that HaloBox systems may have, as identified in the (https://amdcloud-my.sharepoint.com/:w:/g/personal/ldokovic_amd_com/IQDzi0T3kgG8SI8vDoOHYij0AfBkUxsT5bepUPx-_urcYQE?e=frcEzv) report.
By introducing HaloBox, we can distinguish different OS's. It removes unnecessary virtual environment setup on HaloBox, enhancing clarity and efficiency.