fix(types): resolve remaining mypy errors missed by #1253#1296
Open
kovtcharov-amd wants to merge 7 commits into
Open
fix(types): resolve remaining mypy errors missed by #1253#1296kovtcharov-amd wants to merge 7 commits into
kovtcharov-amd wants to merge 7 commits into
Conversation
Suppresses no-any-return in providers and factory, fixes Optional defaults in database.py, adds type: ignore for file_watcher redefs, casts TransitionStatus in checkpoint_bridge.
github-actions
Bot
added
llm
added 2 commits
May 29, 2026 10:27
…faults - checkpoint_bridge.py: add `from typing import cast` and CheckpointStatus import - factory.py: suppress no-any-return on dynamic provider instantiation - claude.py: fix vision() to materialize Iterator[str] before returning - database.py: fix update_session Optional defaults, create_session return type
PathValidator.create_backup() creates timestamped backups like file.YYYYMMDD_HHMMSS.bak.py, not file.py.bak. The assertion was checking the wrong path, causing a flaky failure.
added 2 commits
May 29, 2026 10:50
…up test - database.py: fix all Optional defaults in add_message/update_session, fix return types for add_document/add_message, type params list as Any - test_code_agent.py: fix second backup assertion in integration test
- database/mixin.py: add assert narrowing after _require_db() - device.py: cast registry value to str - installer/mcp_init.py: annotate config_data dict - rag/pdf_utils.py: annotate positions list - testing/mocks.py: wrap return in dict() - ui/database.py: fix Optional defaults in update_document_status, get_setting - test_code_agent.py: fix second backup assertion in integration test
added 2 commits
May 29, 2026 11:40
- connectors/store.py: suppress no-any-return on sqlite row returns - api/app.py: use set comprehension for pids (was list assigned to set) - validation_parsing.py: suppress attr-defined for mixin attributes - checklist_generator.py: suppress no-any-return on dict.get returns - session.py: suppress dict-item on error return branch - tools.py: annotate _TOOL_REGISTRY, fix Optional func parameter
…l defaults - tools.py: suppress no-any-return and return-value on get_tool_description - memory_store.py: bulk fix str = None -> str | None = None across all methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1253 fixed the first batch of mypy errors but missed 12 more that surface when the full codebase is linted. These are blocking CI on all open PRs (#1243, #1244, #1245, #1248, #1249). Once this merges and the open PRs rebase, their lint checks will pass.
Test plan
python util/lint.py --allpasses with 0 mypy errors