infra: use apt python3.12 for base image and decouple cudaq image - #481
Open
rmshaffer wants to merge 18 commits into
Open
infra: use apt python3.12 for base image and decouple cudaq image#481rmshaffer wants to merge 18 commits into
rmshaffer wants to merge 18 commits into
Conversation
5 tasks
rmshaffer
force-pushed
the
rmshaffer/base-image-build-speedup
branch
from
May 8, 2026 14:49
38ff561 to
1b4c49e
Compare
Member
|
Do these improvements carry over to the other images? |
Member
Author
The tensorflow and pytorch images are based on SageMaker DLC images, which already have most dependencies. So this particular optimization only matters for the base and cudaq images. |
Contributor
|
Change makes sense to me. Haven't manually built the images to check, but I expect a "simple" MPI job to work with the BASE image and a CUDA-Q MPI job (e.g. the ones in cuda-q notebook 6) to work with the CUDAQ image. |
dtrenev
previously approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Two improvements here:
Switches the base image to apt-installed
python3.12, which reduces build time by ~50% and image size by ~10%.Makes the cudaq image independent of the base image, so that changes to both images can now be built in parallel; no need to wait for a new base image to be published to ECR before rebuilding the cudaq image.
Testing done:
Tested the container builds locally and ran tests.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.