Skip to content

refactor: Make InsertTransaction::GetVertexId private #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhanglei1949 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Make InsertTransaction::GetVertexId private #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/neug/transaction/insert_transaction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,11 @@ class InsertTransaction {
bool GetVertexIndex(label_t label, const execution::Value& oid,
vid_t& lid) const;

execution::Value GetVertexId(label_t label, vid_t lid) const;

PropertyGraph& graph() { return graph_; }

private:
execution::Value get_vertex_id(label_t label, vid_t lid) const;

void create_id_indexer_if_not_exists(label_t label);

void clear();
Expand Down
8 changes: 4 additions & 4 deletions src/transaction/insert_transaction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ bool InsertTransaction::GetVertexIndex(label_t label,
return false;
}

execution::Value InsertTransaction::GetVertexId(label_t label,
vid_t lid) const {
execution::Value InsertTransaction::get_vertex_id(label_t label,
vid_t lid) const {
if (added_vertices_.size() <= label || added_vertices_[label] == nullptr) {
return graph_.GetOid(label, lid, timestamp_);
}
Expand Down Expand Up @@ -126,8 +126,8 @@ Status InsertTransaction::AddEdge(
label_t src_label, vid_t src_vid, label_t dst_label, vid_t dst_vid,
label_t edge_label, const std::vector<execution::Value>& properties,
const void*& prop) {
const auto& src = GetVertexId(src_label, src_vid);
const auto& dst = GetVertexId(dst_label, dst_vid);
const auto& src = get_vertex_id(src_label, src_vid);
const auto& dst = get_vertex_id(dst_label, dst_vid);
const auto& types =
graph_.schema().get_edge_properties(src_label, dst_label, edge_label);
if (properties.size() != types.size()) {
Expand Down
Loading