Upgrade Flutter for flutter_soloud depenency - #235
Open
leaf-node wants to merge 1 commit into
Open
Conversation
This change fixes builds of the flutter_soloud dependency, which uses flutter/flutter#176393 to support conditional inclusion of build artifacts according to the build target: https://github.com/alnitak/flutter_soloud/blob/main/pubspec.yaml#L72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a starting point for fixing F-Droid builds of the flutter_soloud dependency (#232) , which uses
flutter/flutter#176393
to support conditional inclusion of build artifacts according to the build target:
https://github.com/alnitak/flutter_soloud/blob/main/pubspec.yaml#L72
An alternative may be to downgrade
flutter_soloud, which may or may not work out.If you test this patch, you'll also need to update the
pubspec.lockfile. It looks like there are a few listed above the error message in the CI job, but those four are sub-dependencies. I don't know if there is a way to selectively upgrade the lock file... Perhaps doing as suggested: running runflutter pub getwithout--enforce-lockfile, then commit the result. I suspect that keeping the same versions of packages in pubspec.yaml may allow you to upgrade the lock file a little bit without breaking too much compatibility with otherwise working dependencies.