Fix "invalid path" error for UNC paths on Windows - #1277
Open
hamodywe wants to merge 1 commit into
Open
Conversation
resolve_path() only handled Prefix::Disk and Prefix::VerbatimDisk when initializing the path root on Windows, so any UNC path (\server\share, or its \?\UNC\server\share verbatim form) fell through to the catch-all branch and errored with "invalid path", even though the path itself was perfectly valid. This broke zoxide entirely for anyone whose directories live on a network share. Add a Prefix::UNC / Prefix::VerbatimUNC arm that builds the \server\share root the same way the Disk arms build their drive root, and add resolve_path unit tests covering UNC, verbatim UNC, and a disk-path regression check. Fixes ajeetdsouza#331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_path() only handled Prefix::Disk and Prefix::VerbatimDisk when initializing the path root on Windows, so any UNC path (\server\share, or its ?\UNC\server\share verbatim form) fell through to the catch-all branch and errored with "invalid path", even though the path itself was perfectly valid. This broke zoxide entirely for anyone whose directories live on a network share.
Add a Prefix::UNC / Prefix::VerbatimUNC arm that builds the \server\share root the same way the Disk arms build their drive root, and add resolve_path unit tests covering UNC, verbatim UNC, and a disk-path regression check.
Fixes #331