fix(message): correctly concat base64-encoded data block deltas#31
Merged
DavdGao merged 2 commits intoJun 2, 2026
Merged
Conversation
DavdGao
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DATA_BLOCK_DELTAwas appended with naive string concatenation. When each delta is an independently base64-encoded chunk whose raw byte length isn't a multiple of 3, the per-chunk = padding gets spliced into the middle of the stream, corrupting the result on decode.Fix: decode existing and incoming chunks, concat the raw bytes, and re-encode — so the accumulated value equals
base64(concat(rawBytes)).Test updated to use chunks that exercise mid-stream padding (
AQI=+Aw==→AQID); the old string-concat path would have silently passed before.Checklist
Please check the following items before the code is ready to be reviewed.
pnpm formatpnpm test)