fix(harness): 统一 workspace 列表路径归一化，修复 project 目录下 file_list 异常#1719
Open
guslegend0510 wants to merge 4 commits into
Open
fix(harness): 统一 workspace 列表路径归一化，修复 project 目录下 file_list 异常#1719guslegend0510 wants to merge 4 commits into
guslegend0510 wants to merge 4 commits into
Conversation
AgentScopeJavaBot
added
bug
AgentScopeJavaBot
left a comment
AgentScopeJavaBot
left a comment
Collaborator
There was a problem hiding this comment.
🤖 AI Review
This PR unifies workspace file list path normalization by introducing Workspace.getFilePath() and fixes SandboxProject.fileList's incorrect path resolution logic. It also removes a dangerous exists() short-circuit in saveProject().
Recommendation: COMMENT — 1 critical issue + 1 recommended + 1 nitpick
AgentScopeJavaBot
left a comment
AgentScopeJavaBot
left a comment
Collaborator
There was a problem hiding this comment.
🤖 AI Review
This PR unifies workspace file list path normalization by introducing Workspace.getFilePath() and fixes SandboxProject.fileList's incorrect path resolution logic. It also removes a dangerous exists() short-circuit in saveProject().
Recommendation: COMMENT — 1 critical issue + 1 recommended + 1 nitpick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
在配置
LocalFilesystemSpec的project/workspace后，file_list相关列表接口会出现路径格式不一致的问题，导致 project 目录下的文件展示异常。修改
WorkspaceManager的列表路径归一化逻辑knowledge、memory、tasks、sessions等glob结果knowledge和memory的 workspace-relative 路径输出验证
WorkspaceManagerListingTestmvn验证时，仓库中已有的Session/SessionKey相关编译问题会先阻塞构建