Fix integer out of bounds issue - #20
Open
TERMSTRAANGE wants to merge 1 commit into
Open
Conversation
Convert data to int16 type during operation. As an alternative, data could be initially loaded as `int16` as opposed to default `uint8` as defined by `np.memmap` which is used to load the samples.
There was a problem hiding this comment.
Pull request overview
This PR fixes an integer out of bounds issue when processing SDR (Software Defined Radio) data by explicitly converting uint8 data to int16 before performing arithmetic operations with a negative ADC offset.
Key Changes:
- Explicit type conversion to int16 added before arithmetic operations with the ADC offset (-127)
- Prevents potential integer underflow when adding negative offset to unsigned uint8 data
- Applied consistently to both IQ (in-phase and quadrature) components in complex data construction
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| calibratesdr/utils.py | Added astype(np.int16) conversion in get_fft function for both real and imaginary data slices before adding adc_offset |
| calibratesdr/dabplus/dab.py | Added astype(np.int16) conversion in get_ppm function for IQ data components before adding adc_offset |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert data to int16 type during operation. As an alternative, data could be initially loaded as
int16as opposed to defaultuint8as defined bynp.memmapwhich is used to load the samples.