Skip to content

fix(0004): use snake case for pattern variable#414

Merged
toumorokoshi merged 4 commits into
aep-dev:mainfrom
kindermoumoute:4-variable-dash
Jun 7, 2026
Merged

fix(0004): use snake case for pattern variable#414
toumorokoshi merged 4 commits into
aep-dev:mainfrom
kindermoumoute:4-variable-dash

Conversation

@kindermoumoute

@kindermoumoute kindermoumoute commented Jun 4, 2026

Copy link
Copy Markdown
Contributor
  • fix the literal regex to support 1-character segments
  • add rule to use snake case on pattern variables
  • typo on one of the example

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

Updated regex for 'literal' and clarified pattern variable requirements.
@kindermoumoute kindermoumoute requested a review from a team as a code owner June 4, 2026 09:19
Comment thread aep/general/0004/aep.md.j2 Outdated
Co-authored-by: Yusuke Tsutsumi <tsutsumi.yusuke@gmail.com>

@toumorokoshi toumorokoshi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@toumorokoshi toumorokoshi merged commit 2195a57 into aep-dev:main Jun 7, 2026
2 checks passed
@kindermoumoute kindermoumoute deleted the 4-variable-dash branch June 7, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants