feat(a11y): playwright, axe, actions, fixtures, tests - #55
Draft
marissahuysentruyt wants to merge 12 commits into
Draft
feat(a11y): playwright, axe, actions, fixtures, tests#55marissahuysentruyt wants to merge 12 commits into
marissahuysentruyt wants to merge 12 commits into
Conversation
marissahuysentruyt
added
🚧 WIP
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Comment on lines
+20
to
+21
| with: | ||
| node-version: 20 |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| with: | |
| node-version: 20 | |
| with: | |
| node-version: 24 |
Collaborator
Author
There was a problem hiding this comment.
node 20 actions are deprecated so all of the workflows might need updating.
marissahuysentruyt
force-pushed
the
a11y-testing
branch
from
August 7, 2026 20:17
b14afdf to
02ee4f5
Compare
marissahuysentruyt
force-pushed
the
a11y-testing
branch
from
August 13, 2026 15:27
ae77110 to
f8d0fd1
Compare
Adds a toMatchAriaSnapshot() test per block, alongside the existing axe scans, to catch semantic regressions (a heading demoted, a landmark losing its name, a role getting clobbered) that axe's rule-based scan won't flag on its own. Gated to a single chromium run per block via testInfo.project.name, since Mobile Chrome also runs on the Chromium engine and would otherwise duplicate the check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds a parallel test/a11y/custom-components/ suite (one fixture + spec per element, mirroring the block convention) for the 8 shared se-* components, since relying on incidental coverage from whichever block happens to use a component misses states like disabled/error/checked and, for se-checkbox and se-segmentedcontrol, missed the element entirely. Extends coverage.spec.js to parse customElements.define() calls out of se.js so a newly added element can't ship untested. Surfaced several real, pre-existing bugs (left failing and documented, consistent with how other known a11y issues are tracked in this suite): se-checkbox's touch target is below the WCAG 2.2 AA minimum, dark mode is broken for every form element except se-button, se-textarea has no accessible label at all, and se-dialog's buttons render with insufficient contrast. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
| "eslint-plugin-chai-friendly": "^1.1.0", | ||
| "eslint-plugin-import": "^2.32.0", | ||
| "globals": "^17.0.0", | ||
| "serve": "^14.2.6", |
Collaborator
Author
There was a problem hiding this comment.
we can remove this now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots (if applicable)
Type of change
Related issue(s)
Validation steps
To Validate
URL for testing:
https://a11y-testing--spectrum-hub--adobe.aem.page/
npm testand confirm all tests passnpm run lintand confirm no linting errorsaem upAccessibility testing checklist
Device review
Checklist: