feat(data-access): extend DOMAIN_PATTERN to support subpath domains (LLMO-4187)#1593
Open
Kanishkavijay39 wants to merge 1 commit intomainfrom
Open
feat(data-access): extend DOMAIN_PATTERN to support subpath domains (LLMO-4187)#1593Kanishkavijay39 wants to merge 1 commit intomainfrom
Kanishkavijay39 wants to merge 1 commit intomainfrom
Conversation
…on (LLMO-4187) Update DOMAIN_PATTERN to accept nba.com/kings-style subpath domains alongside plain hostnames, and add IPv4 rejection via negative lookahead. Schema length check now applies to the hostname only so subpaths don't count against the 253-char DNS limit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Kanishkavijay39
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLMO-4187 — Subpath URL support for ASO PLG & LLMO onboarding
Problem
Domain validation in
PlgOnboardingused a regex that only accepted plainhostnames (e.g.
nba.com). Subpath domains likenba.com/kingswererejected, blocking PLG and LLMO customers from self-onboarding subpath sites.
Changes
plg-onboarding.model.jsDOMAIN_PATTERNto allow optional path segments after the hostname(e.g.
nba.com/kings,nba.com/us/kings)127.0.0.1are rejectedplg-onboarding.schema.jsdomainattribute length check to measure the hostname only(
value.split('/')[0].length <= 253) so the path segment doesn't countagainst the 253-char DNS limit
Valid after this change
nba.comwww.nba.comnba.com/kingsnba.com/us/kingshttps://nba.com127.0.0.1nba.com?q=1nba.com#topPlease ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!