feat: Add missing hold affordance icon for longPress S2 MenuTriggers#10066
Open
LFDanLu wants to merge 5 commits into
Open
feat: Add missing hold affordance icon for longPress S2 MenuTriggers#10066LFDanLu wants to merge 5 commits into
LFDanLu wants to merge 5 commits into
Conversation
|
Build successful! 🎉 |
Member
Author
| */ | ||
| isQuiet?: boolean; | ||
| /** @private */ | ||
| holdAffordance?: boolean; |
Member
There was a problem hiding this comment.
just add to the context interface?
Member
Author
There was a problem hiding this comment.
oh good point, I guess I could use the same context in the Chromatic instead of using the prop directly too
| } | ||
| }; | ||
|
|
||
| export const HoldAffordance: Story = { |
Member
There was a problem hiding this comment.
maybe we make it look a bit more like real ones?
Here's how photoshop uses something similar
Member
Author
|
@snowystinger docs actually already exist for this under https://d1pzu54gtk2aed.cloudfront.net/pr/899e2671cf58a48cccbd21dd428eb34cbc67dada/ haha, definitely easy to miss. I didn't realize the same thing until I wrote some new docs and went through a whole debugging session ugh I'll put the above in the test instructions too |
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10029
Adds the hold affordance icon to "longPress" MenuTriggers in S2. Supports ActionButton and ToggleButton triggers
✅ Pull Request Checklist:
📝 Test Instructions:
Test the new story and see chromatic.
Also test the pre-existing docs and make sure the affordance icon and behavior works as expected.
🧢 Your Project:
RSP