fix(useFocusVisible): use Object.defineProperty to wrap HTMLElement.prototype.focus#10041
Open
antododo wants to merge 1 commit into
Open
fix(useFocusVisible): use Object.defineProperty to wrap HTMLElement.prototype.focus#10041antododo wants to merge 1 commit into
antododo wants to merge 1 commit into
Conversation
1300068 to
6fbb592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9649
✅ Pull Request Checklist:
📝 Test Instructions:
yarn jest packages/react-aria/test/interactions/useFocusVisible.test.js— all 18 tests pass, including the new regression testdoes not throw when HTMLElement.prototype.focus is an accessor-only property.src/change, keep the new test, and rerun the command above. The new test should fail withTypeError: Cannot set property focus of [object HTMLElement] which has only a getter. Re-apply thesrc/change and the test passes.yarn jest packages/react-aria/test/interactions/— all 237 tests pass.Object.definePropertycall is equivalent to the previous assignment against the defaultHTMLElement.prototype.focusdata descriptor).🧢 Your Project:
While building components on
react-aria-componentsfor Swissquote.ch internal design system where consumers' Jest+JSDOM test suites using@testing-library/user-event'ssetup()crash on import of any RAC-using component.