Conversation
…add test coverage getEditPath became async to resolve the correct editor route, which left the Edit link briefly pointing at an empty href before it resolved. Remove the href/target until ready and dim the link instead. Also switch the internal getEditorRoute helper to destructured params to match sibling utils, and add test coverage for the EW-flag/editor.path route resolution logic. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: since this makes
getEditPathasync, and there is also a very similar function in https://github.com/adobe/da-live/blob/main/blocks/browse/shared.js, sorta feels like we should make this a single global util, and/or pre-load the config so that function need not be async....To be Continued...
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: