CEXT-6527: add upgrade type surface and optional leaf-step upgrade capability - #614
Merged
iivvaannxx merged 4 commits intoAug 10, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 7160797 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iivvaannxx
force-pushed
the
CEXT-6527/upgrade-types
branch
from
August 6, 2026 16:30
00ddc66 to
e8d5355
Compare
iivvaannxx
marked this pull request as ready for review
August 6, 2026 16:30
oshmyheliuk
approved these changes
Aug 7, 2026
obarcelonap
approved these changes
Aug 7, 2026
obarcelonap
left a comment
Member
There was a problem hiding this comment.
LGTM but I added many comments on try to do not prefix much with upgrade since at the end at some point we may want to use this interfaces for installation too
iivvaannxx
force-pushed
the
CEXT-6527/upgrade-types
branch
from
August 7, 2026 10:13
e8d5355 to
1812828
Compare
iivvaannxx
force-pushed
the
CEXT-6527/upgrade-types
branch
from
August 7, 2026 10:14
1812828 to
dfa0ed2
Compare
Collaborator
Author
|
@obarcelonap You're right, forgot that we intended to reuse the machinery for installation and uninstallation. I generalized things, please see commit dfa0ed25 (and resolve your comments as you see fit). |
jcuerdo
approved these changes
Aug 7, 2026
…pability Add the upgrade orchestration types (step capability in common/workflow, orchestration models in upgrade), optional planUpgrade/upgrade handlers on leaf steps authored via defineLeafStep, a placeholder webhooks adoption, and a shared LifecycleRequestContext reused across lifecycle actions.
iivvaannxx
force-pushed
the
CEXT-6527/upgrade-types
branch
from
August 10, 2026 18:33
1abfd6a to
74fbb7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the upgrade orchestration type surface and folds an optional upgrade capability onto leaf steps:
management/common/workflow/upgrade.ts(UpgradeCapability,UpgradeDomainPlan,UpgradeOperation,UpgradePlanningInput/UpgradePlanningResult,UpgradeExecutionContext/UpgradeExecutionResult,CleanupResource,CleanupIdentityOf,UpgradeIssue).management/upgrade/(UpgradePlan,StoredUpgradeAttempt,StateSnapshot,UpgradeOrchestrationState,SuccessfulUpgradeResult,UpgradeRequestContext).LeafStepgains optionalplanUpgrade/upgradehandlers, authored via the singledefineLeafStephelper (no separate step type).TODO) adoption in the webhookssubscriptionsStep, specialized to the webhook domain types.LifecycleRequestContext(incommon/schema.ts) reused by the installation action andUpgradeRequestContext.Reuses installation's engine 1:1 —
UpgradeIssuemirrorsValidationIssuefor the planning channel, and a failed attempt'sfailurereusesWorkflowError. There is no upgrade runtime yet; these are coordination contracts for parallel workstreams.Related Issue
CEXT-6527
Motivation and Context
Multiple workstreams (domain handlers, the orchestrator, the management UI) need to build against the upgrade lifecycle in parallel. This delivers the type surface plus a first placeholder domain adoption so they can start against a stable, reviewed contract.
Notes for reviewers:
planUpgraderesult shape (UpgradePlanningResult) is reconstructed from the HLD and should be confirmed with the orchestrator workstream.planUpgrade/upgradepairing is a documented convention (both are optional onLeafStep), not type-enforced.How Has This Been Tested?
pnpm --filter @adobe/aio-commerce-lib-app typecheck— clean.pnpm --filter @adobe/aio-commerce-lib-app test— all pass, includingexpectTypeOfcoordination-contract tests for the upgrade generics.pnpm --filter @adobe/aio-commerce-lib-app build— emits.d.tsfor the new public exports.pnpm --filter @adobe/aio-commerce-lib-app lint/lint:openapi— clean.Types of changes
Checklist: