docs(security): add Data Privacy & Compliance section to security-and-hardening - #470
Open
HMAKT99 wants to merge 2 commits into
Open
docs(security): add Data Privacy & Compliance section to security-and-hardening#470HMAKT99 wants to merge 2 commits into
HMAKT99 wants to merge 2 commits into
Conversation
Adds a Data Privacy & Compliance section to security-and-hardening: PII/sensitive classification, data minimization + purpose, retention/deletion paths (incl. backups), data-subject rights (GDPR/CCPA), consent for third-party/vendor sharing, and data residency. Complements the hardening content (can an attacker read it) with the privacy question (should we hold it, and for how long).
…ression The privacy trigger phrase used generic verbs (collecting, storing, retaining, deleting, sharing) that pulled the security skill's routing rank above other skills on unrelated prompts. Replacing with a tight 'personal data or privacy compliance' phrase preserves discoverability without over-triggering.
addyosmani
approved these changes
Aug 8, 2026
addyosmani
left a comment
Owner
There was a problem hiding this comment.
This is the right home for it, thanks for moving it into security-and-hardening after the earlier round. The data classification plus operating rules reads well and it's in scope here. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
security-and-hardeningalready owns the answer to "can an attacker read this data?" This PR adds the companion question agents currently have no guidance on: "should we even hold this data, and for how long?" — a separate concern that hardening alone doesn't answer.Addy's closing note on #347 was: "Data privacy and compliance fit security-and-hardening rather than a separate section; closing here, a focused addition to that skill would be welcome." This is that addition.
Why it belongs in security-and-hardening
PII encrypted at rest— this PR gives agents the classification framework they need to answer that checkbox correctly.Content (+33 lines, one file)
A new
## Data Privacy & Compliancesection covering four actionable decisions:1. Classify fields as you add them — PII classification table (non-personal / personal PII / sensitive) with handling rules per class. Agents can't protect or delete what they haven't classified.
2. Four operating rules — minimize and state a purpose before collecting; set retention up front and build a working deletion path (including backups, caches, indexes); support data-subject rights (export, correct, delete) by designing the schema to be findable and erasable; get auditable consent before sharing PII with third parties or vendors.
3. Cross-references without duplication — points to
observability-and-instrumentationfor the "never log PII" rule (already there), and todebugging-and-error-recoveryfor breach-notification timing in postmortems. No content duplicated.4. Three Verification checkboxes added to the existing checklist:
Also adds three rationalization rows and three red flags to the existing sections.
What this is not
This is not a GDPR compliance guide. It's the minimum a coding agent needs to avoid building systems that fail deletion requests, send PII to analytics vendors without consent, or collect fields with no stated purpose. Legal detail belongs elsewhere; engineering decisions belong here.
Validator: 0 errors, 0 warnings. One file. Frontmatter description unchanged (no routing surface added).