Skip to content

Added support for decryption of RAR files - #1

Merged
adamhathcock merged 25 commits into
adamhathcock:masterfrom
hrasyid:master
Jul 16, 2013
Merged

Added support for decryption of RAR files #1
adamhathcock merged 25 commits into
adamhathcock:masterfrom
hrasyid:master

Conversation

@hrasyid

@hrasyid hrasyid commented Jul 16, 2013

Copy link
Copy Markdown
Contributor

As discussed in e-mail, here is the pull request which include RAR decryption. Please review and make any changes if necessary. Note that currently there is still problem due to inavailability of Cryptography in Portable.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this please.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert please.

@adamhathcock

Copy link
Copy Markdown
Owner

Thanks for doing this again. We can discuss any or all of the comments.

@hrasyid

hrasyid commented Jul 16, 2013

Copy link
Copy Markdown
Contributor Author

Thanks Adam for the review. I reverted the signature-related stuff and updated the code according to your comment

adamhathcock added a commit that referenced this pull request Jul 16, 2013
Added support for decryption of RAR files
@adamhathcock
adamhathcock merged commit a162197 into adamhathcock:master Jul 16, 2013
norvegec referenced this pull request in KOLANICH-libs/sharpcompress May 17, 2015
1) disabled requirement of signature
2) added runtime discovery of folder with archives

changes by this commit are already present in 13ef1c3
adamhathcock pushed a commit that referenced this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants