Skip to content

bump MSC buffer for RP2040 boards exposing SD-over-USB #10964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikeysklar wants to merge 1 commit into from
Closed

bump MSC buffer for RP2040 boards exposing SD-over-USB #10964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ports/raspberrypi/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,22 @@ CFLAGS += \
-DCFG_TUD_CDC_RX_BUFSIZE=256 \
-DCFG_TUD_MIDI_TX_BUFSIZE=128 \
-DCFG_TUD_CDC_TX_BUFSIZE=256 \
-DCFG_TUD_MSC_BUFSIZE=1024 \
-DPICO_RP2040_USB_DEVICE_UFRAME_FIX=1 \
-DPICO_RP2040_USB_DEVICE_ENUMERATION_FIX=1 \

# CFG_TUD_MSC_BUFSIZE: 1024 bytes is enough for internal flash MSC but
# causes macOS bulk-IN endpoint stalls on RP2040 during multi-sector SD
# card READ(10) probes. Boards that expose an SD card over USB MSC can
# opt into a larger buffer by setting CIRCUITPY_USB_MSC_LARGE_BUFFER = 1
# in their mpconfigboard.mk. Costs ~15 KB RAM; only worth enabling when
# the board actually has SD hardware exposed over USB MSC.
# Root cause tracked at hathach/tinyusb.
ifeq ($(CIRCUITPY_USB_MSC_LARGE_BUFFER),1)
CFLAGS += -DCFG_TUD_MSC_BUFSIZE=16384
else
CFLAGS += -DCFG_TUD_MSC_BUFSIZE=1024
endif

# option to override default optimization level, set in boards/$(BOARD)/mpconfigboard.mk
CFLAGS += $(OPTIMIZATION_FLAGS)

Expand Down
Loading