CIRCUITPY_FULL_BUILD now controls a few more features#10152
Merged
tannewt merged 1 commit intoadafruit:mainfrom Mar 20, 2025
Merged
CIRCUITPY_FULL_BUILD now controls a few more features#10152tannewt merged 1 commit intoadafruit:mainfrom
tannewt merged 1 commit intoadafruit:mainfrom
Conversation
dhalbert
force-pushed
the
use-full-build-for-some-features
branch
from
9f80a58 to
df33271
Compare
tannewt
approved these changes
Mar 20, 2025
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Yay for consistency! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10134 added
PY_FUNCTION_ATTRSandPY_REVERSE_SPECIAL_METHODSto most of thempconfigport.hfiles. It occurred to me that these should be controlled byCIRCUITPY_FULL_BUILD(which is on by default), with some exceptions for "small" full builds on SAMD21.So this refactors that change to
circuitpy_mpconfig.h.I also turned on
MICROPY_PY_BUILTINS_NOTIMPLEMENTEDmore consistently.I also went through the language-feature flags in
py/mpconfig.hto see if there were new ones we had missed. I may open a sort of "notes" issue about that later.Testing in draft mode first to see how the sizes work out.