fix(layout): make fullscreen only apply to focused window#352
Open
qeude wants to merge 1 commit intoacsandmann:mainfrom
Open
fix(layout): make fullscreen only apply to focused window#352qeude wants to merge 1 commit intoacsandmann:mainfrom
qeude wants to merge 1 commit intoacsandmann:mainfrom
Conversation
Previously, toggling fullscreen on a window and then cycling focus would leave the unfocused fullscreen window covering the screen, causing it to stay in the background and obscure other windows. Fullscreen state now persists on nodes, but layout calculation only applies screen bounds when the node is in the focused path. This affects Traditional, BSP, and Scrolling layout systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Toggling fullscreen on a window and then cycling focus (e.g. via
NextWindow/PrevWindow) would leave the unfocused fullscreen window covering the entire screen, causing it to stay in the background and obscure other tiled windows.Solution
Fullscreen state (
is_fullscreen/is_fullscreen_within_gaps) now persists on nodes, but layout calculation only applies screen/gap bounds when the node is in the focused selection path.Changes
apply_with_gapschecksis_focusedbefore expanding to fullscreen rectcalculate_layout_recursiveonly fullscreens the selected leafcalculate_layoutonly fullscreens the selected windowhas_any_fullscreen_nodeonly returnstruewhen the fullscreen node is focusedTests
Added unit tests for Traditional, BSP, and Scrolling layouts covering:
fullscreen_within_gapsrespects focus state