fix: properly sleep between animation frames#328
Open
yuukidach wants to merge 1 commit into
Open
Conversation
Timer::sleep(duration) creates a Future but was never awaited, causing animation frames to execute in a tight loop with no delay. Use std::thread::sleep instead since Animation::run() is synchronous.
yuukidach
force-pushed
the
fix/animation-sleep
branch
from
c662abb to
bb8a581
Compare
Contributor
|
Wonder if something like this would also help to interpolate animation more smoothly or is it overkill? (Bevy uses this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Timer::sleep(duration)inAnimation::run()creates aFuturebut never.awaits it, so it's immediately dropped — animation frames execute in a tight loop with no delaystd::thread::sleep(duration)sincerun()is a synchronous function, properly pacing frames at the configured FPS (default 100fps over 300ms)