fix(security): 2 improvements across 2 files - #9417
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Unsafe YAML deserialization using yaml.load with CLoader - Security: Unsafe YAML deserialization using yaml.load with CLoader Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Unsafe YAML deserialization using yaml.load with CLoader - Security: Unsafe YAML deserialization using yaml.load with CLoader Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Collaborator
|
@mjpost @mbollmann Should we just delete all the outdated scripts under bin/ that process the YAML files? Or archive them somewhere? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:bin/split_venues.py:L17The script uses
yaml.load(f, Loader=Loader)whereLoaderis imported asCLoader. WhileCLoaderis generally safer than the standardLoader, it is not a Safe Loader. Usingyaml.loadwithout explicitly specifying a Safe Loader can lead to arbitrary code execution if a malicious YAML file is processed. The code should useyaml.safe_load()or explicitly specifyCSafeLoader.Solution
Replace
yaml.load(f, Loader=Loader)withyaml.safe_load(f)or ensureLoaderisyaml.CSafeLoader.Changes
bin/split_venues.py(modified)bin/normalize_joint_yaml.py(modified)