Skip to content

XML minimal diff saving bug with text markup #9326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nschneid merged 7 commits into from
Jul 29, 2026
Merged

XML minimal diff saving bug with text markup #9326

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
30b317e
text markup tags (including new ones from #6484) need to be listed as…
nschneid Jul 26, 2026
a69d03d
ruff
nschneid Jul 26, 2026
59cbb7b
Correct TAGS_WITH_MARKUP and update test cases
mbollmann Jul 26, 2026
b618848
Prevent ensure_minimal_diff from recursing into markup elements
mbollmann Jul 26, 2026
9f867fc
<par/> does not contain markup
nschneid Jul 28, 2026
d13541f
CHANGELOG parens
nschneid Jul 28, 2026
4d40dd4
merge CHANGELOG
nschneid Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions python/acl_anthology/utils/xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@
TAGS_WITH_MARKUP = {
"b",
"i",
"u",
"sc",
"tt",
"par",
"a",
"url",
"tex-math",
Comment thread
nschneid marked this conversation as resolved.
Outdated
"fixed-case",
"title",
"abstract",
Expand Down
17 changes: 17 additions & 0 deletions python/tests/utils/xml_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ def test_xml_indent(inp, out):
"<title><i>Italics</i><b>Bold</b></title>",
False,
),
( # Formatting markup differences are not logically equivalent
"<abstract><b>Important</b> message</abstract>",
"<abstract>Important message</abstract>",
False,
),
)


Expand Down Expand Up @@ -388,6 +393,18 @@ def test_xml_assert_equals(a, b, should_be_equal):
<attachment type="software" hash="079d4f4b">2022.acl-long.48.software.zip</attachment>
</paper>""",
),
# Requires TAGS_WITH_MARKUP to include <tex-math>
(
"<abstract><tex-math>a</tex-math> <b>xxx</b></abstract>",
"<abstract><tex-math>a</tex-math> xxx</abstract>",
"<abstract><tex-math>a</tex-math> <b>xxx</b></abstract>",
),
# Requires TAGS_WITH_MARKUP to include <par/>
(
"<abstract>a<par/><b>xxx</b></abstract>",
"<abstract>a<par/>xxx</abstract>",
"<abstract>a<par/><b>xxx</b></abstract>",
),
)


Expand Down
Loading