Skip to content

Fix min_index assignment in corner calculations - #162

Open
viivsion wants to merge 1 commit into
aces-aswf:mainfrom
viivsion:main
Open

Fix min_index assignment in corner calculations#162
viivsion wants to merge 1 commit into
aces-aswf:mainfrom
viivsion:main

Conversation

@viivsion

Copy link
Copy Markdown

arranged into a cycle with the lowest JMh hue value at index [1]

arranged into a cycle with the lowest JMh hue value at index [1]

Signed-off-by: viivsion <49360870+viivsion@users.noreply.github.com>
@linux-foundation-easycla

linux-foundation-easycla Bot commented May 19, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: viivsion / name: viivsion (54a588f)

@CLAassistant

CLAassistant commented May 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@scottdyer

scottdyer commented May 21, 2026

Copy link
Copy Markdown
Contributor

This does seem a valid fix, since in the original blink code this line is indeed written as min_index = i.

Can you provide a litte background about what prompted this review?
Do you have any comments on the implication of this change? Is it fixing a particular error you encountered?

EDIT: I guess what I'm trying to ask is - I'd love to know a bit more about what brought you to this file. Did you happen to encounter a specific image artifact or interpolation error in highly saturated gradients that led you here? Because if you have an example image where this bug visibly breaks, it would help us document the real-world impact of the fix. This is a clear logic flaw that will get fixed, just trying to make sure we can communicate when and where it might matter if implementers don't patch it right away.

@viivsion

Copy link
Copy Markdown
Author

This change has no impact on RGB images. I only noticed this code‑writing issue while studying the code, and this conditional branch is never triggered under normal RGB images.

@scottdyer scottdyer added this to 2.0.1 Jun 6, 2026
@github-project-automation github-project-automation Bot moved this to Todo in 2.0.1 Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants