Implement ELASTIC wasi-security - #277
Open
Michielvk wants to merge 3 commits into
Open
Conversation
Contributor
|
@Michielvk, can we use Metadata rather than having a new entry on the task? |
Contributor
Author
@rodneyosodo, this was the original plan, but it turns out that the Metadata field is only used by the Manager and stripped while creating the Since we need these additional configs in the Proplet to configure Wasmtime, we decided during the Belgrade meeting to add a new field instead that is intended to supply custom config to the Proplet directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
New feature as part of the ELASTIC project. As discussed and agreed upon by all partners during the technical meeting in Belgrade.
What does this do?
This PR allows a user to supply an additional config file to the Proplet. The Proplet parses this config file and configures Wasmtime accordingly.
Have you included tests for your changes?
Yes. All pass.
Did you document any new/modified features?
Yes. And an example config file is available.