Allow WASM targets to pre-define ABSL_HAVE_MMAP#2048
Open
andreaTP wants to merge 1 commit intoabseil:masterfrom
Open
Allow WASM targets to pre-define ABSL_HAVE_MMAP#2048andreaTP wants to merge 1 commit intoabseil:masterfrom
andreaTP wants to merge 1 commit intoabseil:masterfrom
Conversation
WASM/WASI build systems using wasi-sdk need to pass -DABSL_HAVE_MMAP alongside -D_WASI_EMULATED_MMAN to enable emulated mmap support. The #error guard on ABSL_HAVE_MMAP blocks this. Exempt __wasm__ targets from the guard while keeping it for all other platforms. Add a CI script that builds abseil-cpp with wasi-sdk to catch WASI build regressions.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
Why is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋 !
Thank you so much for maintaining Abseil, it's an amazing library and we really appreciate all the work that goes into it!
This is a tiny follow-up to #1976 . When building Abseil for WASM/WASI with wasi-sdk, build systems need to pass
-DABSL_HAVE_MMAPalongside-D_WASI_EMULATED_MMAN. The #error guard onABSL_HAVE_MMAPprevents this.This PR exempts
__wasm__targets from that guard (1 line changed), while keeping it intact for all other platforms. It also adds a CI script that builds Abseil withwasi-sdkto prevent regressions, I can remove it and leave the single line change when requested.This patch (or equivalent) is already working in the wild across several projects, for example:
Having this upstream would let all these projects drop their local patches. Thank you for considering it!