fix: modernize Sublist3r for Python 3.11/3.12 compatibility and harden DNSDumpster engine - #412
Open
muhammedabdelkader wants to merge 1 commit into
Open
fix: modernize Sublist3r for Python 3.11/3.12 compatibility and harden DNSDumpster engine#412muhammedabdelkader wants to merge 1 commit into
muhammedabdelkader wants to merge 1 commit into
Conversation
…n DNSDumpster engine
### Changes
- Fixed Python 3.11/3.12 SyntaxWarnings by converting legacy regex patterns
to raw strings (r"...") in sublist3r.py and subbrute.py.
- Ensured compatibility with Homebrew Python environment by aligning
interpreter and dependencies.
- Added robust error-handling wrapper in enumratorBaseThreaded.run()
to prevent engine failures from stopping the entire enumeration.
- Replaced deprecated queue usage with safe list-append logic (self.q.append).
- Refactored DNSDumpster handling:
- Updated req() -> get_csrftoken() interaction.
- Implemented resilient get_csrftoken() that accepts either Response
objects or raw HTML strings.
- Added graceful fallback when CSRF token is missing or HTML structure
changes.
- Normalized logging output to warn but continue execution when engines
such as Google, VirusTotal, or DNSDumpster introduce blocking or CAPTCHAs.
- Improved reliability of multi-threaded enumeration by preventing
AttributeError: "<Engine>Enum" object has no attribute "result".
### Result
Sublist3r now runs successfully on macOS/Homebrew Python 3.11+, with
proper exception handling for deprecated or blocking data sources.
DNSDumpster no longer throws
and all enumeration engines fail gracefully without terminating the scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Result
Sublist3r now runs successfully on macOS/Homebrew Python 3.11+, with proper exception handling for deprecated or blocking data sources. DNSDumpster no longer throws and all enumeration engines fail gracefully without terminating the scan.