Skip to content

Fix 4DN index router reading wrong field path in file document — Closes #26 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
conradbzura wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix 4DN index router reading wrong field path in file document — Closes #26 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b912984
fix: Dispatch 4DN index lookup to DCC-namespaced extras path
conradbzura Apr 14, 2026
08a7b46
test: Cover index router DCC dispatch and range handling
conradbzura Apr 14, 2026
e3b3f85
refactor: Consolidate index router test setup and tighten patch targets
conradbzura Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/cfdb/api/routers/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ async def stream_index_file(
"""
Stream an index file (e.g., .px2, .bai) associated with a DCC file.

Index files are discovered during 4DN API enrichment and stored in
extra.extra_files on the materialized file document.
Index files are discovered during DCC-specific enrichment and stored
under a DCC-namespaced key on the materialized file document. For 4DN
files, sidecar extras live under ``extra.fourdn.extra_files``.

Path Parameters:
dcc: DCC abbreviation (e.g., 4dn) - case insensitive
Expand Down Expand Up @@ -64,9 +65,15 @@ async def stream_index_file(
if not file_doc:
raise HTTPException(status_code=404, detail="File not found")

# Get extra_files from the extra field
extra = file_doc.get("extra", {})
extra_files = extra.get("extra_files", [])
# Get extra_files from the DCC-namespaced subdocument under ``extra``.
# Each DCC enrichment writes sidecar extras under its own key
# (e.g. 4DN → ``extra.fourdn.extra_files``) so we dispatch by DCC.
extra = file_doc.get("extra") or {}
if normalized_dcc == "4dn":
dcc_extra = extra.get("fourdn") or {}
extra_files = dcc_extra.get("extra_files") or []
else:
extra_files = []

if not extra_files:
raise HTTPException(
Expand Down
Loading
Loading