Skip to content

Fix negative def decrease dmg#17

Open
kjagodka wants to merge 1 commit intoa327ex:masterfrom
kjagodka:master
Open

Fix negative def decrease dmg#17
kjagodka wants to merge 1 commit intoa327ex:masterfrom
kjagodka:master

Conversation

@kjagodka
Copy link
Copy Markdown

No description provided.

@BLimmie
Copy link
Copy Markdown

BLimmie commented Aug 2, 2021

Since this only applies to negative numbers, I believe this fix reverses the intended damage calculation. Currently negative defenses close to 0 have damage multipliers slightly greater than 1 [dmg*(2-(1-e))], while large negative defenses have damage multipliers closer to 2 [dmg*(2-e)].

@kjagodka
Copy link
Copy Markdown
Author

kjagodka commented Aug 2, 2021

Since this only applies to negative numbers, I believe this fix reverses the intended damage calculation. Currently negative defenses close to 0 have damage multipliers slightly greater than 1 [dmg*(2-(1-e))], while large negative defenses have damage multipliers closer to 2 [dmg*(2-e)].

I believe it should be like that. But because in the case of negative defense the fraction (100/(100 + NEGATIVE)) actually gets bigger, as the defense gets more negative, because the denominator approaches 0.
This actually makes damage taken to became negative, when defense is between -50 and -100.

plot on wolfram alpha before change

plot on wolfram alpha after change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants