Credential Type Metadata Documents by nodh · Pull Request #566 · a-sit-plus/vck

nodh · 2026-06-10T13:50:57Z

Builds upon #567 to implement a registry of type metadata documents (see https://www.ietf.org/archive/id/draft-ietf-oauth-sd-jwt-vc-16.html#name-sd-jwt-vc-type-metadata) that can be translated into internal credential schemes.

Actually resolve remote type metadata documents in #571.

Other credential schemes are migrated into a-sit-plus/credentials-collection#1

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a330fd267

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af4d8f48db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…emes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f2f3aa79d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5935628f7f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62d7b345cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Data classes have been integrated into VC-K

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88c16dd7ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-17T11:12:39Z

+        identifier: String,
+        representation: CredentialRepresentation,
+    ): Boolean {
+        val extensions = vckExtensions


Resolve inherited VCK extensions before matching

The fresh issue is that this matcher still inspects the unresolved child definition, so a static metadata document that extends a PID/mDL/JWT base and relies on the now-inherited vckExtensions has extensions == null here. In that case PLAIN_JWT/ISO_MDOC lookup by the inherited vcType/isoDocType never finds the child vct, and AttributeIndex falls back instead of resolving and merging the document; this affects bundled/static country- or issuer-specific extensions unless every child repeats the full vck block or has an alias.

Useful? React with 👍 / 👎.

should be easy to provoke or disprove with a test

JesusMcCloud

will report back on the note to self later

JesusMcCloud · 2026-06-17T13:16:28Z

+        identifier: String,
+        representation: CredentialRepresentation,
+    ): Boolean {
+        val extensions = vckExtensions


should be easy to provoke or disprove with a test

JesusMcCloud · 2026-06-17T14:47:18Z

+        while (true) {
+            val current = load()
+            if (compareAndSet(current, transform(current))) return
+        }


this function is also available as a built-in.

nodh self-assigned this Jun 10, 2026

nodh force-pushed the feature/dynamic-credential-registry branch 2 times, most recently from 6c3c784 to ecc74c9 Compare June 11, 2026 19:27

nodh added this to the 6.0 milestone Jun 11, 2026

nodh requested a review from JesusMcCloud June 11, 2026 19:28

nodh force-pushed the feature/dynamic-credential-registry branch 2 times, most recently from faa5f84 to 3a330fd Compare June 12, 2026 09:07

nodh mentioned this pull request Jun 12, 2026

Typed Credential Schemes #567

Open

nodh changed the base branch from develop to feature/typed-credential-schemes June 12, 2026 09:09

nodh marked this pull request as ready for review June 12, 2026 09:09

nodh changed the title ~~Dynamic credential registry~~ Credential Type Metadata Documents Jun 12, 2026

chatgpt-codex-connector Bot reviewed Jun 12, 2026

View reviewed changes

Comment thread vck/src/commonMain/kotlin/at/asitplus/wallet/lib/InternalHelpers.kt Outdated

Comment thread vck/src/commonMain/kotlin/at/asitplus/wallet/eupid/EuPidCredential.kt

nodh force-pushed the feature/dynamic-credential-registry branch from 3a330fd to af4d8f4 Compare June 12, 2026 09:14

chatgpt-codex-connector Bot reviewed Jun 12, 2026

View reviewed changes

Comment thread vck/src/commonMain/kotlin/at/asitplus/wallet/eupid/EuPidScheme.kt

Comment thread vck/src/commonMain/kotlin/at/asitplus/wallet/eupid/EuPidCredential.kt Outdated

Comment thread vck/src/commonMain/kotlin/at/asitplus/wallet/eupid/EuPidCredential.kt Outdated

nodh force-pushed the feature/typed-credential-schemes branch from 0e5ca5d to 25ba60f Compare June 17, 2026 09:06

nodh added 3 commits June 17, 2026 11:06

Support extensions for SD JWT Type metadata documents

33e7a0b

Prepare to resolve remote type metadata documents into credential sch…

c2dda27

…emes

Implement credential metadata registry

a3154b9

nodh force-pushed the feature/dynamic-credential-registry branch from af4d8f4 to 4f2f3aa Compare June 17, 2026 09:19

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

nodh force-pushed the feature/dynamic-credential-registry branch from 4f2f3aa to 5935628 Compare June 17, 2026 10:13

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread vck/src/commonMain/kotlin/at/asitplus/wallet/lib/data/StaticCredentialMetadataRegistry.kt

Comment thread ...-type-metadata/src/commonMain/kotlin/at/asitplus/wallet/sdjwt/SdJwtTypeMetadataDefinition.kt Outdated

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread vck/src/commonMain/kotlin/at/asitplus/wallet/eupidsdjwt/EuPidCredentialSdJwt.kt Outdated

nodh force-pushed the feature/dynamic-credential-registry branch from 62d7b34 to c7d06b8 Compare June 17, 2026 11:05

nodh added 6 commits June 17, 2026 13:06

Import data classes for credential schemes

3e21cb2

Switch to dynamically defined credential schemes

546f250

Pre-load static credential scheme type metadata

8154646

Remove submodule for mDL credential

37b195a

Data classes have been integrated into VC-K

Fix concurrent registration of credential schemes

ec0274e

Extract constants for credentials

5af2394

nodh added 3 commits June 17, 2026 13:06

Fix remote lookup

3e3dfd2

Honor integrity checks while preloading static metadata

71b11cc

Inherit VCK extensions when extending metadata

88c16dd

nodh force-pushed the feature/dynamic-credential-registry branch from c7d06b8 to 88c16dd Compare June 17, 2026 11:06

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

nodh mentioned this pull request Jun 17, 2026

Remote Credential Registry #571

Open

JesusMcCloud requested changes Jun 17, 2026

View reviewed changes

nodh modified the milestones: 6.0, 7.0 Jun 18, 2026

Uh oh!

Conversation

nodh commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

JesusMcCloud Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

JesusMcCloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JesusMcCloud Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

JesusMcCloud Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nodh commented Jun 10, 2026 •

edited

Loading