Feature: Default Parameters#5
Open
n0900 wants to merge 5 commits into
Open
Conversation
|
|
||
| private fun registerDefault(thisRef: O, property: KProperty<*>) { | ||
| if (!hasDefault) return | ||
| val defaults = thisRef as? ObjectBackedDefaults<*, *> ?: return |
Contributor
There was a problem hiding this comment.
why can this not be prevented in other ways?
| } | ||
| return thisRef.codec.nullElement() | ||
| } | ||
| return thisRef.codec.encode(serializer, value) |
Contributor
There was a problem hiding this comment.
how is one an accessor and the other an encode call?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds default parameters to
backedPropertyso thatJsonConfiguration.encodeDefaultsis honoredfor slices this is not applicable because default behavior is different:
JsonBackedObjectit returns a read-only view where it tries to deserialize from the underlying raw JsonObject according to the serializer used to define the instance.encodeDefaultsof the serializer used to cast any object toJsonObjectdecides whether it encodes default values or not. It would be wise to hand over this serializer in the constructor but this is not enforcable.