Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying valaxy with
|
| Latest commit: |
bcf8631
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ac2a278f.valaxy.pages.dev |
| Branch Preview URL: | https://fix-709.valaxy.pages.dev |
Deploying valaxy-api with
|
| Latest commit: |
bcf8631
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e02fe33f.valaxy-api.pages.dev |
| Branch Preview URL: | https://fix-709.valaxy-api.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR updates the monorepo’s pnpm catalog/overrides and lockfile to eliminate unmet Vite 8 peer dependency warnings by bumping UnoCSS and unplugin-vue-markdown, and it documents an existing pin for unplugin-vue-components related to override-order behavior.
Changes:
- Bump
unocssfrom66.5.10to66.7.2(catalog + overrides). - Bump
unplugin-vue-markdownfrom^30.0.0to^32.0.0(catalog). - Add a comment documenting the
unplugin-vue-components@28.0.0pin and rationale (#505).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates catalog/overrides for UnoCSS + markdown plugin; documents the vue-components pin. |
| pnpm-lock.yaml | Refreshes the lockfile to reflect the bumped dependency graph and resolved versions. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
🚀 Deployed on https://6a2d09a1972fd3195f7ed94c--valaxy.netlify.app |
… Node >=22.12 (close #709) Under Vite 8, pnpm reported unmet peer dependency warnings: - unocss / @unocss/vite 66.5.10 declared a vite peer up to ^7.0.0-0 only - unplugin-vue-markdown ^30.0.0 declared a vite peer up to ^7.0.0 only Bump both to versions that declare Vite 8 support: - unocss 66.5.10 -> 66.7.2 (catalog + overrides; @unocss/vite@66.7.2 peer is ^5 || ^6 || ^7 || ^8) - unplugin-vue-markdown ^30.0.0 -> ^32.0.0 (vite peer includes ^8.0.0-0) BREAKING CHANGE: minimum Node version is now >=22.12.0 (was ^18 || >=20). unplugin-vue-markdown@32 — the only release that declares Vite 8 peer support — requires Node >=22, and Vite 8 itself requires ^20.19 || >=22.12. The intersection is >=22.12.0. engines.node is updated across the root, valaxy, and create-valaxy manifests, and the docs (getting-started, deploy Dockerfile) and CLAUDE.md are updated to match. CI already runs lts/*. Also declare @unocss/reset explicitly in @valaxyjs/devtools: its client entry imports `@unocss/reset/tailwind.css`, which previously resolved only via a hoisted transitive of unocss 66.5.10. unocss 66.7.2 no longer pulls @unocss/reset into the tree, so a fresh install broke `vite build src/client`. unplugin-vue-markdown has no dependency on unplugin-vue-components, so this bump is unrelated to the #505 override-order bug (still fixed by the separate unplugin-vue-components@28.0.0 pin, now documented in a comment). The vite-ssg / beasties warning in the report no longer applies: the legacy vite-ssg engine was removed in v1.0 (#706). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…on gate `docs/search.spec.ts` gated `page.goto` on `networkidle`, which never settles against the Vite dev server (HMR, UnoCSS dev updates, the git-log addon's GitHub API calls and async DocSearch chunks keep the network busy), so the navigation timed out under CI load — the failure observed on this PR. Switch to `waitUntil: 'domcontentloaded'` + the existing `waitForHydration` helper, which waits for Vue's `data-v-app` attribute — a deterministic "app is interactive" signal that does not depend on the network ever going quiet. Expand the helper docs to explain why networkidle is avoided. theme-yun/index.spec.ts intentionally keeps `networkidle`: its mount on the served demo build is network-gated (external analytics/resources), so `data-v-app` is not a reliable signal there and networkidle is the appropriate wait. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…cs accuracy - devtools: declare every dep its client build imports (vite.config.ts: @vitejs/plugin-vue, unocss, unplugin-vue-components, vite-plugin-vue-devtools, vue-router; main.ts: vue, pinia) instead of relying on workspace hoisting, so `pnpm -C packages/devtools build:client` is self-contained and won't break under stricter installs (same class as the @unocss/reset fix). - docs(getting-started, EN/ZH): reword the Node note — Vite 8 still supports Node 20.19+; Valaxy's >=22.12.0 floor comes from unplugin-vue-markdown@32 (>=22) combined with Vite's ^20.19 || >=22.12 on the Node 22 line. - docs(deploy, EN/ZH): pin the Dockerfile base image to `node:22.12-alpine` so the example matches the documented minimum. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
YunYouJun
added a commit
that referenced
this pull request
Jun 13, 2026
The 1.0 migration guide predated the Node bump (#710), so the most impactful breaking change — dropping Node 18/20 in favour of >=22.12.0 — was undocumented. Add a Node.js section (en + zh) explaining the floor comes from unplugin-vue-markdown@32 (>=22) combined with Vite 8 (^20.19 || >=22.12). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes the unmet peer dependency warnings reported under Vite 8 (#709) by bumping the offending plugins to versions that declare Vite 8 support.
pnpm iwarned that two catalog plugins did not declare Vite 8 in their peer ranges:unocss/@unocss/vite66.5.10→ vite peer capped at^7.0.0-0unplugin-vue-markdown^30.0.0→ vite peer capped at^7.0.0Changes (commit 1 — deps)
unocss66.5.10→66.7.2(catalog andoverrides;@unocss/vite@66.7.2peer is^5 || ^6 || ^7 || ^8).unplugin-vue-markdown^30.0.0→^32.0.0(the only release that declares the Vite 8 peer; includes^8.0.0-0).engines.node^18 || >=20→>=22.12.0across root /valaxy/create-valaxy, plus docs (getting-started EN/ZH, deploy Dockerfile →node:22-alpine) andCLAUDE.md. See below.@unocss/resetexplicitly in@valaxyjs/devtools(catalog + devDependencies) — its client entry imports@unocss/reset/tailwind.css, which previously resolved only via a hoisted transitive ofunocss@66.5.10;66.7.2no longer pulls it in, which brokevite build src/clienton a fresh install.unplugin-vue-components@28.0.0pin (error components override order by unplugin-vue-components #505) with a comment.>=22.12.0unplugin-vue-markdown@32— the only version that declares Vite 8 peer support — requires Node>=22, and Vite 8 itself requires^20.19 || >=22.12. The intersection is>=22.12.0, so Node 18/20 are dropped in v1.0. CI already runslts/*(Node 22+). (Per maintainer decision over keeping markdown on v30 with a residual warning.)#505 safety
unplugin-vue-markdown(v30 and v32) has no dependency onunplugin-vue-components— it still resolves to exactly28.0.0with markdown@32 installed. So this bump is unrelated to the #505 override-order bug, which remains fixed by the separateunplugin-vue-components@28.0.0pin.The
vite-ssg/beastieswarning from the original report no longer applies — the legacyvite-ssgengine was removed in v1.0 (#706).Test hardening (commit 2 —
test(e2e))The PR's first CI run surfaced a flaky Playwright failure:
e2e/docs/search.spec.tsgatedpage.gotoonwaitUntil: 'networkidle', which never settles against the Vite dev server (HMR, UnoCSS dev updates, the git-log addon's GitHub API calls, async DocSearch chunks keep the network busy) → navigation timed out under CI load.waitUntil: 'domcontentloaded'+ the existingwaitForHydrationhelper (waits for Vue'sdata-v-app— a deterministic "app is interactive" signal that doesn't depend on the network going quiet), and expanded the helper docs.e2e/theme-yun/index.spec.tsintentionally keepsnetworkidle: its mount on the served demo build is network-gated (external analytics/resources never resolve in the sandbox), sodata-v-appis not a reliable signal there andnetworkidleis the appropriate wait. Verified that the alternatives break that test.Verification
pnpm i— novite/unocss/unplugin-vue-markdownpeer warningspnpm run build✅ (incl. devtoolsbuild:client) ·docs:build✅ ·build:demo✅pnpm typecheck✅ ·pnpm test295/295 ✅ ·pnpm lint✅Closes #709
🤖 Generated with Claude Code