Add ruff linter

.github/workflows/lintAndFormat.yml

@@ -129,6 +129,9 @@ jobs:
           ln -sfn "$PWD/build/python" install/python
           pyright
 
+      - name: Lint Python (ruff)
+        run: ruff check
+
       - name: Analyze
         id: clang-tidy-fixes
         run: |

.pre-commit-config.yaml

@@ -36,6 +36,12 @@ repos:
           ironenv/.*
         )$
 
+- repo: https://github.com/astral-sh/ruff-pre-commit
+  rev: cb8c523fd4835aba42af70f4cad5568db4df0b6c  # frozen: v0.16.0
+  hooks:
+    - id: ruff-check
+      stages: [pre-push]
+
 # Baseline hygiene: validators run on every commit, fixers gated to pre-push
 - repo: https://github.com/pre-commit/pre-commit-hooks
   rev: 3e8a8703264a2f4a69428a0aa4dcb512790b2c8c  # frozen: v6.0.0

python/CMakeLists.txt

@@ -38,8 +38,10 @@ declare_mlir_python_sources(AIEPythonSources.Utils
   ADD_TO_PARENT AIEPythonSources
   SOURCES
     utils/__init__.py
+    utils/_log_setup.py
     utils/benchmark.py
     utils/config.py
+    utils/tensor_factory.py
     utils/test.py
     utils/ml.py
     utils/npukernel.py

python/compiler/txn2mlir/main.py

@@ -4,11 +4,15 @@
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 #
 
-from aie.ir import *  # pyright: ignore[reportMissingImports, reportAttributeAccessIssue]
-from aie.dialects.aie import *  # pyright: ignore[reportMissingImports]
-
 import argparse
 
+from aie.dialects.aie import (
+    transaction_binary_to_mlir,  # pyright: ignore[reportAttributeAccessIssue]
+)
+from aie.ir import (  # pyright: ignore[reportMissingImports]
+    Context,
+)
+
 
 def main():
     # Parse arguments
@@ -20,7 +24,7 @@ def main():
     # Read the data from the file
     data = args.file.read()
 
-    with Context() as ctx:  # pyright: ignore[reportUndefinedVariable]
+    with Context() as ctx:
         module = transaction_binary_to_mlir(ctx, data)
 
     print(str(module))

python/helpers/dialects/func.py

@@ -2,46 +2,43 @@
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 import inspect
+from functools import update_wrapper
+from typing import Any, List, get_args, get_origin
+
 import numpy as np
-from functools import lru_cache, update_wrapper
-import sys
-from typing import get_args, get_origin, Any, List
 
-from ...extras.meta import op_region_builder  # pyright: ignore[reportMissingImports]
-from ...extras.util import (  # pyright: ignore[reportMissingImports]
-    get_user_code_loc,
-    make_maybe_no_args_decorator,
-)
-from ..util import get_arg_types, NpuDType, try_convert_np_type_to_mlir_type
 from ...dialects._ods_common import (  # pyright: ignore[reportMissingImports]
     get_op_result_or_op_results,
 )
-from ...dialects.func import *  # pyright: ignore[reportMissingImports]
 from ...dialects.func import (  # pyright: ignore[reportMissingImports]
-    FuncOp,
     CallOp,
+    FuncOp,
     ReturnOp,
 )
-from ...ir import (  # pyright: ignore[reportMissingImports]
+from ...extras.dialects.arith import (  # pyright: ignore[reportMissingImports]
+    ScalarValue,
+    index_cast,
+)
+from ...extras.meta import op_region_builder  # pyright: ignore[reportMissingImports]
+from ...extras.util import (  # pyright: ignore[reportMissingImports]
+    get_user_code_loc,
+    make_maybe_no_args_decorator,
+)
+from ...ir import (  # pyright: ignore[reportMissingImports]  # pyright: ignore[reportMissingImports]
     Context,
     FlatSymbolRefAttr,
     FunctionType,
+    IndexType,
     InsertionPoint,
-    OpView,
+    IntegerType,
     Operation,
+    OpResult,
+    OpView,
     Type,
     TypeAttr,
     Value,
 )
-from ...extras.dialects.arith import (  # pyright: ignore[reportMissingImports]
-    ScalarValue,
-    index_cast,
-)
-from ...ir import (  # pyright: ignore[reportMissingImports]
-    IndexType,
-    IntegerType,
-    OpResult,
-)
+from ..util import NpuDType, get_arg_types, try_convert_np_type_to_mlir_type
 
 
 def call(
@@ -139,17 +136,20 @@ def call(
 
 
 def isalambda(v):
-    LAMBDA = lambda: 0
+    # A `def` here would defeat the check: Python only assigns the literal
+    # name "<lambda>" to actual lambda expressions, not to `def`s.
+    LAMBDA = lambda: 0  # noqa: E731
+
     return isinstance(v, type(LAMBDA)) and v.__name__ == LAMBDA.__name__
 
 
 def prep_func_types(sig, return_types):
     assert not (
-        not sig.return_annotation is inspect.Signature.empty and len(return_types) > 0
-    ), f"func can use return annotation or explicit return_types but not both"
+        sig.return_annotation is not inspect.Signature.empty and len(return_types) > 0
+    ), "func can use return annotation or explicit return_types but not both"
     return_types = (
         sig.return_annotation
-        if not sig.return_annotation is inspect.Signature.empty
+        if sig.return_annotation is not inspect.Signature.empty
         else return_types
     )
     if not isinstance(return_types, (tuple, list)):
@@ -162,7 +162,7 @@ def prep_func_types(sig, return_types):
     input_types = [
         p.annotation
         for p in sig.parameters.values()
-        if not p.annotation is inspect.Signature.empty
+        if p.annotation is not inspect.Signature.empty
     ]
     # convert ndarray types to memref types
     assert all(
@@ -233,7 +233,7 @@ def __init__(
         if self._is_decl():
             assert len(self.input_types) == len(
                 sig.parameters
-            ), f"func decl needs all input types annotated"
+            ), "func decl needs all input types annotated"
             self.sym_visibility = "private"
             self.emit()
 

python/helpers/dialects/scf.py

@@ -1,28 +1,29 @@
 # Copyright (C) 2024-2026 Advanced Micro Devices, Inc.
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
-import numpy as np
+from contextlib import contextmanager
 from typing import Sequence
 
-from ...ir import (  # pyright: ignore[reportMissingImports]
-    IndexType,
-    InsertionPoint,
-    Value,
-)
+import numpy as np
+
 from ...dialects.scf import (  # pyright: ignore[reportMissingImports]
-    IfOp,
     ForOp,
+    IfOp,
     yield_,
 )
+from ...extras import types as T  # pyright: ignore[reportMissingImports]
 from ...extras.dialects.arith import (  # pyright: ignore[reportMissingImports]
     constant,
     index_cast,
 )
 from ...extras.util import (  # pyright: ignore[reportMissingImports]
     get_user_code_loc,
 )
-from contextlib import contextmanager
-from ...extras import types as T  # pyright: ignore[reportMissingImports]
+from ...ir import (  # pyright: ignore[reportMissingImports]
+    IndexType,
+    InsertionPoint,
+    Value,
+)
 
 
 def _for(

python/helpers/taplib/__init__.py

@@ -6,3 +6,9 @@
     TensorAccessSequence,
 )
 from .tensortiler2d import TensorTiler2D
+
+__all__ = [
+    "TensorAccessPattern",
+    "TensorAccessSequence",
+    "TensorTiler2D",
+]

python/helpers/taplib/tap.py

@@ -3,10 +3,11 @@
 
 from __future__ import annotations
 
+import itertools
 from copy import deepcopy
+from typing import Generator, Sequence
+
 import numpy as np
-import itertools
-from typing import Sequence, Generator
 
 from .utils import (
     validate_and_clean_sizes_strides,