-
Notifications
You must be signed in to change notification settings - Fork 45
[AIE] Add inner-loop versioning to pipeline small-trip-count loops #1078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mludevid
wants to merge
4
commits into
aie-public
Choose a base branch
from
mludevid.loop.versioning.public
base: aie-public
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e126c8d
[AIE][NFC] Drop dead SWP epilogue trip-count plumbing
mludevid 09069a4
[AIE2][AIE2P][AIE2PS] Add loop-version-threshold intrinsics and pseudos
mludevid 0384959
[AIE] Patch versioned-loop guard threshold in the post-pipeliner
mludevid 8cca6fe
[AIE] Add inner-loop-versioning IR pass
mludevid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,7 @@ | |
| #include "llvm/Support/CommandLine.h" | ||
| #include "llvm/Support/Debug.h" | ||
| #include "llvm/Support/ErrorHandling.h" | ||
| #include "llvm/Support/MathExtras.h" | ||
| #include <limits> | ||
|
|
||
| #define DEBUG_TYPE "aie-codegen" | ||
|
|
@@ -424,6 +425,26 @@ void AIEBaseInstrInfo::adjustTripCount(MachineInstr &MI, int Adjustment) const { | |
| Imm.setImm(Imm.getImm() + Adjustment); | ||
| } | ||
|
|
||
| bool AIEBaseInstrInfo::isLoopVersionThresholdDef(const MachineInstr &MI) const { | ||
| auto Opcode = getLoopVersionThresholdOpcode(); | ||
| return Opcode && MI.getOpcode() == *Opcode; | ||
| } | ||
|
|
||
| void AIEBaseInstrInfo::setLoopVersionThreshold(MachineInstr &MI, | ||
| int MinTripCount) const { | ||
| assert(isLoopVersionThresholdDef(MI)); | ||
| // The threshold materializes into a narrow scalar-move immediate; enforce the | ||
| // narrowest field width (AIE2's simm10) across subtargets. A stage count is | ||
| // tiny in practice, so this only trips on a pathological schedule. Checked | ||
| // unconditionally, not just under assert: a truncated threshold would select | ||
| // the high-trip-count copy for trip counts too small for the schedule, a | ||
| // miscompile. | ||
| if (!isInt<10>(MinTripCount)) | ||
|
F-Stuckmann marked this conversation as resolved.
|
||
| report_fatal_error("AIE loop versioning: threshold does not fit the " | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a matter of taste ;-). This fatal is in TII, but the message resembles something emitted by the loop versioning pass. |
||
| "scalar-move immediate"); | ||
| MI.getOperand(1).setImm(MinTripCount); | ||
| } | ||
|
|
||
| bool AIEBaseInstrInfo::isHardwareLoopStart(unsigned Opcode) const { | ||
| const auto ZOLSupport = getZOLSupport(); | ||
| return ZOLSupport && Opcode == ZOLSupport->LoopStartOpcode; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can cost the opcode