[Tests] Tolerate extra robust_rmtree retry from real NFS removal#1609
Open
merkelmarrow wants to merge 1 commit into
Open
[Tests] Tolerate extra robust_rmtree retry from real NFS removal#1609merkelmarrow wants to merge 1 commit into
merkelmarrow wants to merge 1 commit into
Conversation
robust_rmtree stubs a failed tree removal due to ENOTEMPTY twice then calls a real shutil.rmtree and asserts that attempts=3. But that third call might fail with a real ENOTEMPTY, so assert attempts >= 3 instead. Signed-off-by: Marco Blackwell <mblackwe@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A robust_rmtree test is very rarely flaky because it stubs a failed tree removal due to ENOTEMPTY (NFS race) twice, then calls a real shutil.rmtree and asserts that "calls == 3". But that third call might fail with a real ENOTEMPTY. This patch changes the assertion to >= 3 calls to remove this transient issue.