refactor: extract rendering logic into dedicated HtmlRenderer class#80
Merged
Conversation
Add HtmlRenderer class with per-instance rendering configuration (formatted, quoted, useForwardSlash). This eliminates shared mutable static state in the rendering path, making it safe for concurrent use in async contexts (Swoole, ReactPHP, RoadRunner). The renderer can be used standalone: $renderer = new HtmlRenderer(formatted: true, quoted: true); echo $renderer->render($node); Existing toHTML()/toXML() methods on HTMLNode remain unchanged for backward compatibility. 100% test coverage on HtmlRenderer (92 lines, 11 methods). Closes #64 Closes #61
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #80 +/- ##
============================================
+ Coverage 98.31% 98.40% +0.08%
- Complexity 917 967 +50
============================================
Files 6 7 +1
Lines 1843 1946 +103
============================================
+ Hits 1812 1915 +103
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract HTML/XML rendering from HTMLNode into a standalone
HtmlRendererclass with per-instance configuration and no shared mutable state.Motivation
HTMLNode uses static variables (
$IsFormatted,$IsQuoted,$UseForwardSlash) as global state shared across all instances. CallingsetIsQuotedAttribute(true)on any node changes behavior for every other node. This is unsafe in async contexts. Fixes #64 and #61.Changes
WebFiori\Ui\HtmlRendererclass with local rendering staterender(HTMLNode $node, int $initTab = 0): string— produces HTMLrenderXML(HTMLNode $node, bool $formatted = false): string— produces XMLformatted,quoted,useForwardSlashoptionstoHTML()/toXML()on HTMLNode remain unchanged (backward compatible)How to Test / Verify
31 tests, 45 assertions, 100% coverage. Full suite: 352 tests pass.
Breaking Changes and Migration Steps
None. This is additive —
HtmlRendereris a new class. Existing API is untouched.Checklist
composer fix-cs)Related issues
Closes #64, Closes #61