Skip to content

Feat: blocked user#2490

Open
lionellbriones wants to merge 4 commits into
masterfrom
feat/blocked-user
Open

Feat: blocked user#2490
lionellbriones wants to merge 4 commits into
masterfrom
feat/blocked-user

Conversation

@lionellbriones
Copy link
Copy Markdown
Contributor

@lionellbriones lionellbriones commented May 20, 2026

Jira Link

Description

How has this been tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note

Medium Risk
Introduces a new modal status and error-code-specific handling (5120) that changes the login/error UI flow and state transitions. Risk is moderate because it affects user-facing authentication error handling and modal visibility logic, though it’s scoped and largely additive.

Overview
Adds a new MODAL_STATUS.BLOCKED flow that is triggered when connector errors surface error.code === 5120, storing a blockedUserConfig in modal state and rendering a dedicated blocked screen in Loader.

Plumbs blockedUserConfig from UIConfigLoginModal state → RootLoader, updates widget close/visibility behavior to account for BLOCKED, and extends @web3auth/no-modal errors with code 5120 plus a WalletLoginError.userBlocked() helper.

Reviewed by Cursor Bugbot for commit 2583007. Bugbot is set up for automated code reviews on this repo. Configure here.

@lionellbriones lionellbriones requested a review from a team as a code owner May 20, 2026 08:38
@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3auth-web Ready Ready Preview, Comment May 21, 2026 7:09am

Request Review

const handleChangeWallet = () => {
// TODO: wire up real action in a follow-up commit
log.info("change wallet");
};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked user button has no functional action

High Severity

The handleChangeWallet callback in BlockedStatus only calls log.info("change wallet") and performs no actual action. This button is rendered prominently to blocked users (with default text "Change wallet") but clicking it does nothing. Combined with the fact that onCloseLoader for BLOCKED status hides the modal without resetting status to INITIALIZED, the user is left in a dead-end state with no functional escape path other than a full page reload.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e27d7d9. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2583007. Configure here.

>
{buttonMessage}
</button>
</div>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong CSS class prefix breaks BlockedStatus styling

High Severity

The BlockedStatus component uses the w3a-- prefix for all utility CSS classes (e.g., w3a--flex, w3a--text-center, w3a--bg-app-primary-600) and dark:w3a-- for dark mode. Every other component in this file and across the UI layer uses the wta: prefix for utility classes (e.g., wta:flex, wta:text-center) and wta:dark: for dark mode. The w3a-- prefix is only used in this codebase for specific named component classes like w3a--error-logo and w3a--btn, not for utility classes. This means the entire blocked user screen will render without layout, spacing, text styling, or button styling applied.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2583007. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant