Make git operations non-interactive; gh credential fallback for push#16
Merged
Conversation
Flow subprocesses have no usable TTY, so a git HTTPS credential prompt or an ssh key-passphrase prompt blocks the flow forever instead of failing. Route every git invocation through a new `gitProc` helper that applies a non-interactive environment: GIT_TERMINAL_PROMPT=0 disables the HTTPS prompt, and `-o BatchMode=yes` appended to GIT_SSH_COMMAND disables the ssh passphrase prompt (appended, so a custom command is preserved). git and ssh now fail fast under any configuration. push() additionally injects an additive, github.com-scoped, last-resort credential helper (`!gh auth git-credential`) for that one invocation, so HTTPS pushes authenticate via the gh login the PR flows already require even when git has no credential helper configured. It is appended after any config-file helper (a working setup still wins) and is inert for other hosts and SSH. This fixes flows hanging on "Push branch" when the repo uses an SSH→HTTPS url.insteadOf rewrite with no git credential helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow subprocesses have no usable TTY, so a git HTTPS credential prompt or an ssh key-passphrase prompt blocks the flow forever instead of failing. Route every git invocation through a new
gitProchelper that applies a non-interactive environment: GIT_TERMINAL_PROMPT=0 disables the HTTPS prompt, and-o BatchMode=yesappended to GIT_SSH_COMMAND disables the ssh passphrase prompt (appended, so a custom command is preserved). git and ssh now fail fast under any configuration.push() additionally injects an additive, github.com-scoped, last-resort credential helper (
!gh auth git-credential) for that one invocation, so HTTPS pushes authenticate via the gh login the PR flows already require even when git has no credential helper configured. It is appended after any config-file helper (a working setup still wins) and is inert for other hosts and SSH.This fixes flows hanging on "Push branch" when the repo uses an SSH→HTTPS url.insteadOf rewrite with no git credential helper.