Skip to content

Enable mypy parallel workers in pre-commit #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 5 commits into from
May 19, 2026
Merged

Enable mypy parallel workers in pre-commit #2185

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b70f40
Enable mypy parallel workers in pre-commit
adamtheturtle May 7, 2026
f455ade
Update mypy pre-commit hooks to use fixed worker flag.
adamtheturtle May 7, 2026
813c4c9
Avoid pre-commit-lite autofix conflicts on pull requests.
adamtheturtle May 7, 2026
659b671
Merge remote-tracking branch 'origin/main' into chore/mypy-docs-paral…
adamtheturtle May 19, 2026
b43fa4d
Remove unrelated lint workflow change
adamtheturtle May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,20 +184,22 @@ repos:
- id: mypy
name: mypy
stages: [pre-push]
entry: uv run --extra=dev -m mypy
entry: uv run --extra=dev -m mypy --num-workers=4
Copy link
Copy Markdown

@cursor cursor Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using mypy 2.0 flag with pinned 1.20.2 version

High Severity

The --num-workers=4 flag is a mypy 2.0 feature (parallel type checking), but the project pins mypy[faster-cache]==1.20.2 in pyproject.toml and uv.lock. Since uv run --extra=dev -m mypy resolves to the locked 1.20.2 version, both the mypy and mypy-docs hooks will fail with an unrecognized argument error. The mypy 1.20 release blog and release planning issue (#20726) confirm parallel type checking was planned exclusively for 2.0.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f455ade. Configure here.

language: python
types_or: [python, toml]
pass_filenames: false
additional_dependencies:
- *uv_version

# We do not use --example-workers 0 due to https://github.com/python/mypy/issues/18283
- id: mypy-docs
name: mypy-docs
stages: [pre-push]
entry: uv run --extra=dev doccmd --no-write-to-file --language=python --command="mypy"
entry: uv run --extra=dev doccmd --no-write-to-file --language=python --command="mypy
--num-workers=4"
Copy link
Copy Markdown

@cursor cursor Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc parallelization uses wrong flag

Medium Severity

The mypy-docs hook adds mypy --num-workers=4 inside doccmd --command, but the PR goal is parallel doc-example runs via doccmd --example-workers 4. num-workers only parallelizes work inside one mypy process; doccmd still runs each extracted snippet largely serially, so the intended docs speedup is missing.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b43fa4d. Configure here.

language: python
types_or: [markdown, rst]
additional_dependencies:
- *uv_version

- id: check-manifest
name: check-manifest
Expand Down
Loading