Skip to content

feat: add custom strategy support #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgme-syz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add custom strategy support #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion comet/models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

import numpy as np
import pytorch_lightning as ptl
from pytorch_lightning.strategies.strategy import Strategy
import torch
from torch.utils.data import DataLoader, RandomSampler, SequentialSampler, Subset

Expand Down Expand Up @@ -558,6 +559,7 @@ def predict(
accelerator: str = "auto",
num_workers: int = None,
length_batching: bool = True,
strategy: Union[str, Strategy] = "auto"
) -> Prediction:
"""Method that receives a list of samples (dictionaries with translations,
sources and/or references) and returns segment-level scores, system level score
Expand Down Expand Up @@ -648,7 +650,7 @@ def predict(
logger=False,
callbacks=callbacks,
accelerator=accelerator if gpus > 0 else "cpu",
strategy="auto" if gpus < 2 else "ddp",
strategy=strategy if (gpus < 2 or isinstance(strategy, Strategy)) else "ddp",
enable_progress_bar=enable_progress_bar,
)
return_predictions = False if gpus > 1 else True
Expand Down