PoC: PdfCapabilities flags for selective content extraction - #1282
Open
EdwardBlair wants to merge 2 commits into
Open
PoC: PdfCapabilities flags for selective content extraction#1282EdwardBlair wants to merge 2 commits into
EdwardBlair wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept for the capabilities enum discussed in #980. Builds on top of #1281 (lazy stream loading).
Adds a
PdfCapabilitiesflags enum toParsingOptionsso you can tell PdfPig what you actually need:Flags are
Text,Images,Paths, andAll(the default, so nothing changes for existing users). Could add more (Colors, AcroForms, etc) if this direction makes sense.With
LazyLoading = false(the default), the capabilities flags skip processing of unwanted content which saves CPU but the raw stream bytes are still read into memory by the scanner. Combined withLazyLoading = true, skipped streams are never accessed so the bytes stay on disk - thats where the real memory savings come from.TODO:
ParsingOptionsthrough toPageso we can throw if someone tries to access data they didn't extract (e.g. callingGetImages()whenImageswasn't in capabilities)Depends on #1281.