chore(ui5-date-picker, ui5-range-slider): use i18n bundle in tests instead of hardcoded strings#13529
Merged
Merged
Conversation
…ead of hardcoded strings Replace hardcoded accessible name assertions with i18nBundle.getText() calls so tests remain stable across translation updates.
ilhan007
changed the title
nnaydenow
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i18nBundle.getText()callsRoot cause
DatePicker.cy.tsxasserted"Choose Date for ..."but the English source bundle was changed to"Enter date for ..."in fix(ui5-date-picker): correct mobile dialog header styling and text #13100RangeSlider.cy.tsxasserted"Left handle"/"Right handle"but the English source bundle was changed to"Minimum"/"Maximum"in refactor(ui5-range-slider): refactor ui5-range-slider component #13316Both caused failures on the Translation Delivery PR #13427.
Changes
DatePicker.cy.tsxDatePicker.i18nBundle.getText(DATEPICKER_POPOVER_ACCESSIBLE_NAME, label)RangeSlider.cy.tsxRangeSlider.i18nBundle.getText(RANGE_SLIDER_START_HANDLE_DESCRIPTION)/RANGE_SLIDER_END_HANDLE_DESCRIPTIONTest plan
yarn test:cypress:single cypress/specs/DatePicker.cy.tsxpasses (suite-2)yarn test:cypress:single cypress/specs/RangeSlider.cy.tsxpasses (suite-3)Fixes CI failures in #13427.