feat(table): add support for group rows#13510
Open
aborjinik wants to merge 1 commit into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
|
🚀 Deployed on https://pr-13510--ui5-webcomponents-preview.netlify.app |
KvM2
reviewed
May 15, 2026
KvM2
reviewed
May 15, 2026
KvM2
reviewed
May 15, 2026
KvM2
reviewed
May 15, 2026
KvM2
reviewed
May 15, 2026
KvM2
reviewed
May 15, 2026
Contributor
KvM2
left a comment
There was a problem hiding this comment.
Just a few small comments including some questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the
ui5-table-group-rowcomponent, which allows visually grouping rows under a shared header within the table.What it does
ui5-table-group-rowis a new component that extendsTableRowand renders a single cell spanning all visible columns. It acts as a visual separator and group label between sets of data rows.Key design decisions
_isSelectable,_hasPopin,_isInteractive,_isNavigable,_hasSelector) to disable features that don't apply, keeping feature code unchanged.Object.definePropertyoverrides thecellsanactionsslots with frozen empty arrays, preventing accidental slot content from rendering.isGroupRow()marker — Used by Table core and features to detect group rows withoutinstanceofchecks across shadow DOM.Integration with existing features
TableSelectionMultifilters them viaisGroupRow().aria-roledescription._hasPopin = falseand are skipped during popin state sync to avoid errors.Accessibility
role="row"witharia-roledescriptionset to a translatable "Group Row" string.gridcellwitharia-colspanspanning all visible columns andaria-colindex="1".aria-rowindexnumbering.Files changed
TableGroupRow.ts,TableGroupRowTemplate.tsx,TableGroupRow.cssTableGroupRow.cy.tsxFixes: #10148
CPOUIFTEAMB-2446