Sb employee update fix#135
Open
sbagg wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #119 by removing a full-page hard reload when returning from the employee update flow back to the search view, preserving expected SPA behavior.
Changes:
- Removed
window.location.reload()from the update tool reset flow. - Updated
reset()to navigate back to the search subpage via internal state (this.page = 'employee-select'). - Updated
reset()JSDoc to reflect the new SPA navigation behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
153
to
157
| this.resetDepartmentChecks(); | ||
|
|
||
| window.location.reload(); | ||
|
|
||
| this.page = 'employee-select'; | ||
|
|
||
| this.requestUpdate(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #119