Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates client-side logout behavior so that logout can be triggered via routing and so the Keycloak client logs the user out (via redirect) when token refresh fails.
Changes:
- Update
AppStateModelto useAuthModel.logout()when routing to/logout. - Enable Keycloak
onAuthRefreshErrorhandler to redirect to the logged-out page viaAuthModel.logout(true).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/app/client/src/models/AppStateModel.js | Routes /logout to AuthModel.logout() by injecting/using AuthModel within the app state model. |
| services/app/client/src/elements/ucdlib-iam-app.js | Enables Keycloak onAuthRefreshError handler to trigger logout redirect behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
25
to
28
| set(update) { | ||
| if ( update.location.path.length && update.location.path[0] == 'logout' ){ | ||
| this.logout(); | ||
| this.AuthModel.logout(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.